https://gitlab.synchro.net/main/sbbs/-/commit/4a50048e71c7c6d958acd428
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix invalid type in argument to printf format specifier

CID 319135

Fix the return value of js_socket_sendfilesocket() while we're here (off_t instead of int).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f0127e9d4572f8c1c44536dc
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Check socket writability in JS Socket.send()

BINKP is suddenly frequently hanging on sendsocket() on Vertrauen on Windows (sending files to my Z1 hub) so try this as a solution.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3389aadcb8d3bcc3b428b993
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Revert "Check socket writability in JS Socket.send()"

This reverts commit f0127e9d4572f8c1c44536dcda240c310e18f7d8.

This change was "wrong-headed" per Deuce and broke JS sends on
blocking sockets. Thanks for the help.

This fix for inifinite-wait on send() likely led to the infinite
BinkIT errors/log messages that led to commit 4dd32231.

The real fix for this problem (which can block all other timed
events from running), would be a Socket.poll() on the socket before
send in binkp.js.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ab4eca0e22c1c318db48edf6
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Fix misplaced JS_RESUMEREQUEST() - do thise *before* potential return

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/52d9a03d372792616091e4c6
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Apply socket options from sockopts.ini to sockets created by ListeningSocket()

This socket constructor did not get the global socket options treatment when created (years ago).

This should fix issue #402 as reported by Nelgin and more recently by Keyop.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/7ff687ff15f690410daa0bdb
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Revert "Apply socket options from sockopts.ini to sockets created by ListeningSocket()"

This reverts commit 52d9a03d372792616091e4c66b28d98d711d3b29.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/99e8c77caf4a718768e80e6a
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Revert "Revert "Apply socket options from sockopts.ini to sockets created by ListeningSocket()""

This reverts commit 7ff687ff15f690410daa0bdbe2ecc468ea1b4a41.

We're already passing a sock_init callback (ls_cb) which is supposed to set
the socket options (call set_socket_options), so this change shouldn't be necessary and reportedly caused more issues binding ircd sockets when running ircd.js via jsexec (though I didn't see this myself).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/f9a44f56e2ad13a4373e63cd
Modified Files:
src/sbbs3/js_socket.c
Log Message:
Manual revert of the ListeningSocket contructor "fix" which wasn't necessary

I keep reverting/un-reverting the merge that includes an unrelated logon.cpp change. So just manually remove this new code that was added to attempt to
fix issue #402 since I incorrectly concluded that sockopts.ini wasn't being applied to new sockets created with ListeningSocket().

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net